-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic tutorial #304
Merged
Merged
Basic tutorial #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appear to be some python formatting errors in 4583723. This pull request uses the [psf/black](https://github.com/psf/black) formatter to fix these issues.
There appear to be some python formatting errors in d899c63. This pull request uses the [psf/black](https://github.com/psf/black) formatter to fix these issues.
There appear to be some python formatting errors in 525f2fe. This pull request uses the [psf/black](https://github.com/psf/black) formatter to fix these issues.
Adds a simple tutorial start-to-finish tutorial for DaCapo. Still a few things left to resolve before its ready for merging: - [ ] Loss behaving strangely after the first validation (temporary solution involves giving an extra singleton dimension to the provided data) - [ ] Validation fails (we want to show validation loss/scores, validation outputs across iterations, and how to finally take the best iteration and apply it with the post processing to a volume manually) - [ ] stdout too verbose - [ ] plotting functions should be built into `DaCapo` (there are plotting functions, not sure how to include bokeh plots so I didn't dive too deep into this)
i added few changes. dacapo/dacapo/experiments/tasks/post_processors/threshold_post_processor.py Lines 136 to 149 in 689a5a8
changed to just daisy local but affinity is failing because watershed_postprocess is using segment_blockwise dacapo/dacapo/experiments/tasks/post_processors/watershed_post_processor.py Lines 134 to 149 in 689a5a8
I don't know which is the better solution. i recommend using the old code of watershed for now. Validation are failing because of BlockwiseTask too |
There appear to be some python formatting errors in 25f3812. This pull request uses the [psf/black](https://github.com/psf/black) formatter to fix these issues.
Add a basic in-memory postprocessor for watershed. It doesn't seem to be working that well because prediction seems broken. Here's a picture: ![Figure_1](https://github.com/user-attachments/assets/01c209e3-914e-44a2-85b4-70343b1a984f) I expect the postprocessor to work significantly better if the predictions are done with enough context to avoid the block artifacts and the predictions are post processed properly so that high affinity within objects leads to an affinity of 1 (it looks like its set to 0 here), and a low affinity in the background leads to an affinity of 0 (looks like it is set to 0.5 here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pattonw
Adds a simple tutorial start-to-finish tutorial for DaCapo.
Still a few things left to resolve before its ready for merging:
DaCapo
(there are plotting functions, not sure how to include bokeh plots so I didn't dive too deep into this)