-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fixes and better logs #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See Review comments
dacapo/train.py
Outdated
f"Found weights for iteration {latest_weights_iteration}, but " | ||
f"run {run.name} was only trained until {trained_until}." | ||
) | ||
# raise RuntimeError( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete
dacapo/train.py
Outdated
@@ -157,7 +163,7 @@ def train_run( | |||
|
|||
run.model.eval() | |||
# free up optimizer memory to allow larger validation blocks | |||
run.model = run.model.to(torch.device("cpu")) | |||
# run.model = run.model.to(torch.device("cpu")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
No description provided.