Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorial and issue #209 #269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/Start here.rst
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ Now we need to tell `geomeppy` to match up our surfaces with the correct outside

Last step, let's add some nice big windows. We'll set window to wall ratio (WWR) of 0.6 for all external walls.

>>> idf.set_wwr(0.6)
>>> idf.set_wwr(0.6, construction="Project External Window")

So what have we built? We can export the IDF geometry as an OBJ file, a format that can be imported into a 3D geometry viewer.

Expand Down
2 changes: 1 addition & 1 deletion geomeppy/geom/polygons.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Heavy lifting geometry for IDF surfaces."""
from collections import MutableSequence
from collections.abc import MutableSequence
from itertools import product
from math import atan2, pi
from typing import Any, List, Optional, Tuple, Union # noqa
Expand Down