Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorial and issue #209 #269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maynouf
Copy link

@maynouf maynouf commented Nov 16, 2023

This PR fixes the documentation on the error reported in issue #209

A year ago I posted a fix for the error, but didn't submit any PRs (my bad).

I had the same issue that you had when trying to replicate the tutorial.
Apparently the function set_wwr needs a construction parameter in the function, which by default is None.
I replaced idf.set_wwr(0.6) with idf.set_wwr(0.6,construction="Project External Window"), which I believe is the default for windows defined in idf.set_default_constructions(), and now seems to be working correctly.

The branch from which I am submitting this PR (fix-tutorial) stems from the one called fix-collections, of which I submitted a PR some minutes ago, because without the fix to "collections" it is impossible for me to use the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant