Fix Lyrics fetch for AZLyrics and Genius #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSoup replaced org.jsoup.safety.Whitelist with org.jsoup.safety.Safelist. Purely a naming change, no difference of functionality. This bumps the JSoup version (re: jagrosh#10) and handles the breaking changes. This is needed as the related MusicBot project has recently bumped the JSoup version to 1.15.3 (re: jagrosh/MusicBot@a7be2c4) causing runtime errors as it depends on JLyrics, which depends on a different JSoup version.
To fix test suite errors related to genius, the configuration selectors had to be updated. To fix azLyrics tests: - AZLyrics generates a token that is embedded on the page - Token does not come from a standard API endpoint, rather, it is inlined in a JS file that then embeds the token on input form elements as a hidden attribute (unfortunately can't extract it from the initial page returned from the server) To resolve, I added an optional "token" config section for AZ lyrics that fetches the JS file, extracts the token, and then uses it on subsequent requests.
This was referenced Sep 13, 2022
|
Have you tested these changes and do the tests pass? |
|
Yes, the tests pass for me with these changes -- are there any issues with the tests passing on your end? |
|
I haven't had a chance to test this yet, but I'd imagine that (in the current state of things) if the tests pass then this does indeed work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors from azLyrics and genius (re: #9)
To fix test suite errors related to genius, the configuration selectors had to be updated.
To fix azLyrics tests, new functionality for fetching tokens was added:
To resolve this I added an optional "token" config section for AZ lyrics that fetches the token JS file, extracts the token, and then uses it on subsequent requests.