-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem on retrieve Lyrics #9
Comments
The project is discontinued? @jagrosh |
A-Z Lyrics at some point enabled some measures to prevent scraping. You can test this for yourself by visiting the site, doing a search, and noting the token in the URL. Removing this token and visiting the same page will always return an empty search result. If you want to seek out a fix for A-Z Lyrics, then be my guest. There may be a way to get a temporary token, since the site doesn't require login. |
As for the other tests, there isn't enough information to determine why they are failing. Something I plan to change in this project is adding new methods on the client that throw relevant exceptions instead of just returning |
@jagrosh I knew that, unfortunately the token automatically generates itself after a certain amount of time, would you be able to fix this issue or does it take you so much time? |
It's something I can look into but I don't have a solid timetable for when I'll be able to get to it. |
I appreciate your help. |
I don't know how to compile this, so I can't test this out, but I think I know what A-Z Lyrics is doing. When queried without the token, the response includes a hidden input field named x. The query needs to be resubmitted with this field x. So the idea is something like this: The configuration file would need a line something like this to select the value attribute.
And the lyricsclient would have something like this?
I can think of all sorts of reasons why this isn't going to work, but I hope it helps simplify things a little when you have time to look into this. |
@cantelope I will test for you |
@cantelope it cannot be work |
To fix test suite errors related to genius, the configuration selectors had to be updated. To fix azLyrics tests: - AZLyrics generates a token that is embedded on the page - Token does not come from a standard API endpoint, rather, it is inlined in a JS file that then embeds the token on input form elements as a hidden attribute (unfortunately can't extract it from the initial page returned from the server) To resolve, I added an optional "token" config section for AZ lyrics that fetches the JS file, extracts the token, and then uses it on subsequent requests.
#12 I tested myself this PR, A-Z Lyrics work correctly, soon I check if genius work too. |
@jagrosh Can you please check this? None of the lyrics provider seems to work. Not even currently playing songs. |
Hi,
On the latest version there's some problem on retrieve Lyrics, I tried to build myself this repository but without success:
Are you planning to fix it?
Thanks.
The text was updated successfully, but these errors were encountered: