Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Lyrics cannot be found or poorly displayed #1204

Open
3 tasks done
cantelope opened this issue Aug 29, 2022 · 2 comments
Open
3 tasks done

[Bug Report] Lyrics cannot be found or poorly displayed #1204

cantelope opened this issue Aug 29, 2022 · 2 comments
Labels

Comments

@cantelope
Copy link

Bug Description

Searching for lyrics is very finicky. I hardly ever get results. For example, when searching for Legends Never Die I always get 🚫 Lyrics for legends never die could not be found!

Steps to Reproduce

  1. Set lyrics providers to "A-Z Lyrics". (or any of the others)
  2. Search for "legends never die" (https://www.azlyrics.com/lyrics/againstthecurrent/legendsneverdie.html)
  3. No lyrics found.

Expected Result

I expected the lyrics to be displayed, or a list of results from which to select which lyrics to be displayed.

Debug Output

System Properties:
java.version = 11.0.14.1
java.vm.name = OpenJDK 64-Bit Server VM
java.vm.specification.version = 11
java.runtime.name = OpenJDK Runtime Environment
java.runtime.version = 11.0.14.1+1
java.specification.version = 11
os.arch = amd64
os.name = Linux

JMusicBot Information:
Version = 0.3.8
Owner = 165720973574668288
Prefix = ?
AltPrefix = ?help
MaxSeconds = 0
NPImages = false
SongInStatus = true
StayInChannel = true
UseEval = false
UpdateAlerts = true

Dependency Information:
JDA Version = 4.4.0_352
JDA-Utilities Version = 3.0.5
Lavaplayer Version = 1.3.78

Runtime Information:
Total Memory = 1012
Used Memory = 33

Discord Information:
ID = 913615852706861106
Guilds = 2
Users = 4

Additional Info

A-Z Lyrics:
https://search.azlyrics.com/search.php?q=legends%20never%20die gives me a page with a search text box, rather than search results. I have to click on search again to get the search results. Could this be the probelm on A-Z Lyrics?

Genius:
https://genius.com/api/search?q=legends%20never%20die actually gives a json with results, and the first result is the desired hit. But no lyrics are actually returned by the bot.

Musicmatch
https://www.musixmatch.com/search/legends%20never%20die returns a result, and the bot also returns the lyrics, but the words are all appended without paragraphs making it difficult to read
image
So is musicmatch working? Let's try another search for Somewhere Over The Rainbow (https://www.musixmatch.com/lyrics/Israel-Kamakawiwo%CA%BBole/Somewhere-Over-The-Rainbow)
https://www.musixmatch.com/search/somewhere%20over%20the%20rainbow shows results, but the lyrics bot returns no lyrics.

LyricsFreak
The bot returns the wrong set of lyrics from LyricsFreak, but that is because the site does not have the desired result. So the bot is working fine at least.

Checklist

@SuperKali
Copy link

Duplicated jagrosh/JLyrics#9

@MichailiK
Copy link
Collaborator

MichailiK commented Oct 11, 2022

Although this is an upstream issue, this issue should be kept open, in case people are searching for this.

Will close once we update the dependency on MusicBot & bring out the next release.

@MichailiK MichailiK added the bug label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants