This repository has been archived by the owner on Oct 10, 2021. It is now read-only.
Fix test syntax #10
Merged
Fix test syntax #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://docs.ansible.com/ansible/latest/user_guide/playbooks_tests.html#test-syntax The correct form form tests is as suggested; the old way of using filter syntax produces error in Ansible 2.9 (at least).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://docs.ansible.com/ansible/latest/user_guide/playbooks_tests.html#test-syntax
The correct form form tests is as suggested; the old way of using filter syntax produces error in Ansible 2.9 (at least).
Release pull requests, etc.)
What does this Pull Request do?
The modified line caused an error when runnign the playbook with Ansible 2.9. The proposed change fixes the error by using correct test format as suggested by Ansible documentation
What's new?
Replace
| changedwithis changedin a when test.Issue
Fixes issue #7
How should this be tested?
By running the old and new versions with ansible-playbook. The old version fails with
"The conditional check 'motomo_sql_dump_create | changed' failed. The error was: template error while templating string: no filter named 'changed'. String: {% if motomo_sql_dump_create | changed %} True {% else %} False {% endif %}\n\nThe error appears to be in '/home/user/directory/islandora-playbook/roles/external/Islandora-Devops.matomo/tasks/console_install.yml': line 12, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: restore dump\n ^ here\n"
Interested parties
@Islandora-Devops/committers