Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/anan/pagination #25
base: dev
Are you sure you want to change the base?
Feat/anan/pagination #25
Changes from 13 commits
1f080a8
04ebe8c
c0b2042
c971a65
85f7618
60dd0a2
eb46a43
862a8cd
950f5fb
123bf62
37dabef
0e939f2
7f987fa
a0e0222
32e1377
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ลบ comment นี้ออกไปมันคือ
string[]
ไม่ใช่any[]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ขอ 2 อันนี้เป็น type
number
หน่อยเดี่ยว backend จะส่งมาเป็น type number เหมือนกัน
และมันจะไม่ต้องไป
ParseInt
หลายๆที่หลังจากเปลี่ยน type แล้วพยายามเอา
ParseInt
ออกไปThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
พวกนี้อาจจะต้องเปลี่ยนเป็น props แทนหมายถึงต้อง export ไว้ด้วยละกันเพื่อ custom ทีหลัง
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
เวลา change page ขอแบบให้มีขอบเขตหน่อย
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
เอาอีก if นึงมาครอบตรงนี้มันจะได้ไม่ type error หลังจากนั้น