Feat/anan/pagination #25
Open
+154
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punchanabu
requested changes
Oct 4, 2024
There was a problem hiding this comment.
https://www.youtube.com/watch?v=a1wW0AjQCI8
ฟังเพลงนี้ไประหว่างแก้ pr
| import Dropdown from '../Dropdown/Dropdown.svelte'; | ||
|
|
||
| export let Arrayitem: string[] = []; // Explicitly define the type as any[] | ||
| let currentPage: number | string = 1; |
There was a problem hiding this comment.
ขอ 2 อันนี้เป็น type number หน่อย
let currentPage: number
let itemsPerPage: numberเดี่ยว backend จะส่งมาเป็น type number เหมือนกัน
และมันจะไม่ต้องไป ParseInt หลายๆที่
หลังจากเปลี่ยน type แล้วพยายามเอา ParseInt ออกไป
Comment on lines
+76
to
+84
| <button | ||
| class={cn( | ||
| ' px-4 max-md:px-4 py-2 rounded max-md:scale-75', | ||
| currentPage === page ? 'text-white bg-sucu-pink-02 ' : 'text-black bg-white border' | ||
| )} | ||
| on:click={() => changePage(page)} | ||
| > | ||
| {page} | ||
| </button> |
There was a problem hiding this comment.
เอาอีก if นึงมาครอบตรงนี้มันจะได้ไม่ type error หลังจากนั้น
{#if typeof page === 'number'}
<button>some content</button>
{/if}
Comment on lines
+15
to
+18
| function changePage(page: number | string) { | ||
| currentPage = page; | ||
| paginateItems(); | ||
| } |
There was a problem hiding this comment.
เวลา change page ขอแบบให้มีขอบเขตหน่อย
function changePage(page: number) {
if (page < 1) {
currentPage = 1;
} else if (page > totalPages) {
currentPage = totalPages;
} else {
currentPage = page;
}
}| import { faChevronLeft, faChevronRight } from '@fortawesome/free-solid-svg-icons'; | ||
| import Dropdown from '../Dropdown/Dropdown.svelte'; | ||
|
|
||
| export let Arrayitem: string[] = []; // Explicitly define the type as any[] |
There was a problem hiding this comment.
ลบ comment นี้ออกไปมันคือ string[] ไม่ใช่ any[]
Comment on lines
8
to
13
| let currentPage: number | string = 1; | ||
| let itemsPerPage: string = '5'; // Default items per page | ||
| let totalPages: number = Math.ceil(Arrayitem.length / parseInt(itemsPerPage)); | ||
| let paginatedItems: string[] = []; | ||
|
|
||
| const pageChoice: string[] = ['5', '10', '15']; |
There was a problem hiding this comment.
พวกนี้อาจจะต้องเปลี่ยนเป็น props แทนหมายถึงต้อง export ไว้ด้วยละกันเพื่อ custom ทีหลัง
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
pagination component+ responsive
Screenshots or GIFs (if applicable)