LG 01-06 add data, not just data models #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gernotstarke
added
learning content
gernotstarke
requested review from
skogsbaer,
alxlo,
mikesperber,
programming-wolf and
rhoadesre
|
Build Successful! You can find a link to the downloadable artifacts below. |
|
Mentioning "data" only in the heading but speaking only of "data models" in the bullet points feels somewhat pointless. A second point, albeit somewhat nitpicking: for me you do not design data. Data simply exists, and you design models which can be used to represent the data. |
alxlo
reviewed
Oct 28, 2024
The term "design" is still mentioned in the content, though...
alxlo
previously approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Last iteration is fine by me. @skogsbaer what do you think?
sippsack
approved these changes
Oct 28, 2024
|
Looks good! |
|
Looks good to me |
alxlo
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #660