Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier/scenarios/netrid] Factor away test step fragment for flight presence from scenario #862

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mickmis
Copy link
Contributor

@mickmis mickmis commented Dec 10, 2024

Stacked on top of #861, please review last commit only.

This factors away from the RID nominal_behavior scenario as test step fragment the 'flight presence' checks.
Those checks are reused across DP and SP polling, and there are some slight differences between them:

  • Premature flight check: no change
  • Missing flight check: the SP check covers more requirements than the DP one. However IMO it looks appropriate to have all those requirements covered for both SP and DP (NET0710,1 and NET0340 added on top of NET0610).
  • Lingering flight check:
    • for v19: both SP and DP had NET0270 as requirement
    • for v22a: SP has NET0270, and DP has NET0260, but with an issue: the requirement is not linked thus not covered by the check
    • I've decided to change all those by the requirement NET0260,NearRealTime which IMO looks appropriate here, and extends the requirements coverage. Please LMK if you think that is not OK.

@mickmis mickmis merged commit 424a6b4 into interuss:main Dec 12, 2024
20 checks passed
@mickmis mickmis deleted the rid/flightpresence branch December 12, 2024 08:39
github-actions bot added a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants