Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier/scenarios/netrid] Move recent positions checks to display_data_evaluator from common_data_dictionary #863

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

mickmis
Copy link
Contributor

@mickmis mickmis commented Dec 10, 2024

This PR moves the 'recent positions' checks from common_data_dictionary to display_data_evaluator. This is to align check documentation with implementation, as those recent positions checks are not part of the common data dictionary.

Those checks are implemented into evaluate_sp_flight_recent_positions_times and evaluate_sp_flight_recent_positions_crossing_area_boundary.
In addition some necessary refactorings are included:

  • Rename evaluate_sp_flights to evaluate_sp_flight and simplify its arguments
  • Inline _evaluate_recent_position_time into evaluate_sp_flight_recent_positions_times
  • Set functions _chronological_positions and _sliding_triples as static
  • In _evaluate_normal_sp_observation take flight from mapping instead of from sp_observation: this avoids redoing the work of mapping a flight to a participant ID and query

Copy link
Member

@BenjaminPelletier BenjaminPelletier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that @barroco might want to provide some input, but LGTM

…to display_data_evaluator from common_data_dictionary
@mickmis mickmis merged commit 3f6b88a into interuss:main Dec 16, 2024
20 checks passed
@mickmis mickmis deleted the rid/eval-sp-flight branch December 16, 2024 12:04
github-actions bot added a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants