[uss_qualifier] scenario config: fix message_signing and validate qualifier run #713
+39
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
message-signing-fixes
branch
2 times, most recently
from
b02d03f
to
8653ccd
Compare
|
Taking this to draft, as the message_signing suite should skip the |
Shastick
force-pushed
the
message-signing-fixes
branch
4 times, most recently
from
a78fa3f
to
78685e9
Compare
Shastick
force-pushed
the
message-signing-fixes
branch
from
6a6ca8c
to
098815a
Compare
…eractions from mock_uss
…lifier run This PR: - introduces a `validation` block to the `message_signing` configuration, so that we may more easily detect errors - adds a separate `FlightIntentsResource` that contains conflicting flights that all share the `0` priority - use the above new resource to fix `message_signing`, as what is tested by `message_signing` does not support different priorities Test Plan: I started by introducing the validation, which correctly detected the failure. Introducing the new resource then fixed the problem, and a run of `./run_locally.sh configurations.dev.message_signing` then succeeded.
Shastick
force-pushed
the
message-signing-fixes
branch
2 times, most recently
from
ac7fcf7
to
ed81c1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
validationblock to themessage_signingconfiguration, so that we may more easily detect errorspriority_preemption_flightstouft/message_signing.yamlas priorities are not supportedThis should result in:
conflict_higher_priorityscenario to be skippedResolves #693
Test Plan:
I started by introducing the validation, which correctly detected the failure.
Fixing the configuration, the test suite then passes.