Skip to content

Commit

Permalink
[uss_qualifier] scenario config: fix message_signing and validate qua…
Browse files Browse the repository at this point in the history
…lifier run

This PR:
 - introduces a `validation` block to the `message_signing` configuration, so that we may more easily detect errors
 - adds a separate `FlightIntentsResource` that contains conflicting flights that all share the `0` priority
 - use the above new resource to fix `message_signing`, as what is tested by `message_signing` does not support different priorities

Test Plan:
I started by introducing the validation, which correctly detected the failure.

Introducing the new resource then fixed the problem, and a run of `./run_locally.sh configurations.dev.message_signing` then succeeded.
  • Loading branch information
Shastick committed Jun 11, 2024
1 parent 1f423f9 commit 78685e9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,15 @@ v1:
action:
test_suite:
suite_type: suites.faa.uft.message_signing
# Note: suite cannot currently accept flights that conflict due to different priorities,
# which is why priority_preemption_flights is not populated here.
resources:
mock_uss: mock_uss
flight_planners: flight_planners
combination_selector: combination_selector
conflicting_flights: che_conflicting_flights
invalid_flight_intents: che_invalid_flight_intents
non_conflicting_flights: che_non_conflicting_flights
priority_preemption_flights: che_conflicting_flights
dss: scd_dss
dss_instances: scd_dss_instances
id_generator: id_generator
Expand Down
2 changes: 0 additions & 2 deletions monitoring/uss_qualifier/suites/faa/uft/message_signing.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ resources:
dss_crdb_cluster: resources.interuss.crdb.CockroachDBClusterResource?
conflicting_flights: resources.flight_planning.FlightIntentsResource
non_conflicting_flights: resources.flight_planning.FlightIntentsResource
priority_preemption_flights: resources.flight_planning.FlightIntentsResource
invalid_flight_intents: resources.flight_planning.FlightIntentsResource
id_generator: resources.interuss.IDGeneratorResource
utm_client_identity: resources.communications.ClientIdentityResource
Expand All @@ -27,7 +26,6 @@ actions:
mock_uss: mock_uss
conflicting_flights: conflicting_flights
non_conflicting_flights: non_conflicting_flights
priority_preemption_flights: priority_preemption_flights
flight_planners: flight_planners
nominal_planning_selector: combination_selector
invalid_flight_intents: invalid_flight_intents
Expand Down

0 comments on commit 78685e9

Please sign in to comment.