Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier] move SCD dss-specific scenarios to DSS subdir #559

Merged

Conversation

Shastick
Copy link
Contributor

@Shastick Shastick commented Mar 14, 2024

More recent dss-specific scenarios have all been added to the dss subdir. This PR moves these scenarios there too:

  • OpIntentReferenceAccessControl
  • DSSInteroperability


[`IDGeneratorResource`](../../../../resources/interuss/id_generator.py) providing the operational intent reference IDs for this scenario.

### planning_area
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right conceptual resource to use. The thing we want when the PUT calls are made is the information for an actual operational intent, and I think that's best provided via a flight intent. A planning area is an area in which flights might be planned and it would be very unlikely that a flight would take up the entire planning area. Even if it's programmatically valid, I don't think we want to set a conceptual example to equate an operational intent's extents with a planning area.

As a side note, it looks like we should be using more of the flight intent information that we are instead hardcoding -- e.g., the op intent state is hardcoded to Accepted even though the provided flight intent may indicate InUse rather than Planned.

Copy link
Contributor Author

@Shastick Shastick Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an important point.

I opted for often not using the flight intents as requirements about authentication, synchronization and proper handling of interactions seem like they can be comprehensively checked with relatively simple areas, and we can programmatically make sure to cover every possible state of an OIR.

Flight intents seem to come with some machinery that is often not strictly required (although I'd need to double-check that impression), possibly we could introduce another kind of resources that represents a realistic operational intent volume?

(The motivation for removing the flight intents here was to end up with a relatively simple configuration for probing only a DSS. However that's not a hard requirement)

In the present case, I'll revert to the previous version of the scenario but keep the move to the dss subdirectory

@Shastick Shastick force-pushed the move-simplify-op-intent-ref-access-check branch 2 times, most recently from 045d264 to 94fba8a Compare March 19, 2024 10:35
@Shastick
Copy link
Contributor Author

Reverted to use the flight intents, and the OIR state is now read from them.

@Shastick Shastick force-pushed the move-simplify-op-intent-ref-access-check branch 3 times, most recently from 46b1e65 to 0541b05 Compare March 20, 2024 13:00
@Shastick Shastick changed the title [uss_qualifier] simplify dependencies of op-intent ref access control, move to dss dir [uss_qualifier] move SCD dss-specific scenarios to DSS subdir Mar 20, 2024
@Shastick Shastick force-pushed the move-simplify-op-intent-ref-access-check branch from a95648f to b372d0a Compare March 20, 2024 13:23
@Shastick Shastick force-pushed the move-simplify-op-intent-ref-access-check branch from b372d0a to 9171f7d Compare March 20, 2024 13:27
@Shastick Shastick requested a review from barroco March 20, 2024 13:27
@barroco
Copy link
Contributor

barroco commented Mar 20, 2024

Scope of the PR has been reduced to simple move of files.

@barroco barroco merged commit 1ca6a5b into interuss:main Mar 20, 2024
9 checks passed
@barroco barroco deleted the move-simplify-op-intent-ref-access-check branch March 20, 2024 13:54
github-actions bot added a commit that referenced this pull request Mar 20, 2024
[uss_qualidier] move dss-specific test scenarios to the dss subdirectory 1ca6a5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants