Skip to content

Commit

Permalink
Merge branch 'main' into move-simplify-op-intent-ref-access-check
Browse files Browse the repository at this point in the history
  • Loading branch information
Shastick authored Mar 20, 2024
2 parents 0541b05 + b887ee1 commit a95648f
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,12 @@ Query the updated subscription at every DSS provided in `dss_instances`.

When queried for a subscription that was mutated via another DSS, a DSS instance is expected to provide a valid subscription.

If it does not, it might be in violation of **[astm.f3548.v21.DSS0005,5](../../../../../requirements/astm/f3548/v21.md)**.
If it does not, either one of the primary DSS or the DSS that returned the subscription is in violation of one of the following requirements:

**[astm.f3548.v21.DSS0005,5](../../../../../requirements/astm/f3548/v21.md)**, if the API is not working as described by the OpenAPI specification;
**[astm.f3548.v21.DSS0215](../../../../../requirements/astm/f3548/v21.md)**, if the DSS through which the subscription was mutated is returning API calls to the client before having updated its underlying distributed storage.

As a result, the DSS pool under test is failing to meet **[astm.f3548.v21.DSS0020](../../../../../requirements/astm/f3548/v21.md)**.

#### [Subscription is synchronized](../fragments/sub/sync.md)

Expand Down Expand Up @@ -142,6 +147,11 @@ Attempt to query and search for the deleted subscription in various ways
#### 🛑 Secondary DSS should not return the deleted subscription check

If a DSS returns a subscription that was previously successfully deleted from the primary DSS,
either one of the primary DSS or the DSS that returned the subscription is in violation of **[astm.f3548.v21.DSS0210,1a](../../../../../requirements/astm/f3548/v21.md)**.
either one of the primary DSS or the DSS that returned the subscription is in violation of one of the following requirements:

**[astm.f3548.v21.DSS0210,1a](../../../../../requirements/astm/f3548/v21.md)**, if the API is not working as described by the OpenAPI specification;
**[astm.f3548.v21.DSS0215](../../../../../requirements/astm/f3548/v21.md)**, if the DSS through which the subscription was deleted is returning API calls to the client before having updated its underlying distributed storage.

As a result, the DSS pool under test is failing to meet **[astm.f3548.v21.DSS0020](../../../../../requirements/astm/f3548/v21.md)**.

## [Cleanup](../clean_workspace.md)
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ def _validate_get_sub_from_secondary(

with self.check(
"Subscription returned by a secondary DSS is valid and correct",
[secondary_dss.participant_id],
[secondary_dss.participant_id, self._primary_pid],
) as check:
# Do a full validation of the subscription as a sanity check
SubscriptionValidator(
Expand Down Expand Up @@ -584,7 +584,7 @@ def _confirm_secondary_has_no_sub(self, secondary_dss: DSSInstance):
fetched_sub = secondary_dss.get_subscription(self._sub_id)
with self.check(
"Secondary DSS should not return the deleted subscription",
[secondary_dss.participant_id],
[secondary_dss.participant_id, self._primary_pid],
) as check:
if fetched_sub.status_code != 404:
check.record_failed(
Expand Down

0 comments on commit a95648f

Please sign in to comment.