Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add endpoint for handle deposit change status #90

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

OlegPhenomenon
Copy link
Contributor

@OlegPhenomenon OlegPhenomenon commented Sep 25, 2023

close #internetee/auction_center#1130
related #internetee/auction_center#1148

What's this?
This PR is related to this ticket #internetee/auction_center#1130. The essence is that when a deposit status is updated on the auction side, the same status is not updated in the billing system. This can lead to a situation where the auction has one status and the billing system has another, making it difficult to determine which is the source of truth.

What did you do?
I added a new controller that receives user and auction data, searches for the required invoice through pattern matching in the invoice table description field, and updates its status. I also wrote tests to check how the status is correctly parsed and the invoice is found.

How to check?
You need to check how different statuses are changed in the billing system when the administrator changes the deposit status in the auction.

How to review?

  • Make sure the code is clean.
  • Make sure the tests cover all functionalities.
  • Ensure that the code does not add additional complexity and does not affect the functionality of other parts of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants