added service object for notify billing about change status of deposit and added tests #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: Legend: |
OlegPhenomenon
force-pushed
the
1130-deposit-status-change-no-effect-to-billing
branch
5 times, most recently
from
a26c858 to
9555cfe
Compare
OlegPhenomenon
force-pushed
the
1130-deposit-status-change-no-effect-to-billing
branch
from
9555cfe to
1a48660
Compare
maricavor
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1130
What's here?
There is a problem with synchronizing the deposit status between the auction and the billing system. When the status is updated in the auction, no request notifies the billing system that the status needs to be updated, because there is no such implementation. This creates some complexity in determining who is the source of truth for the deposit status.
How did you solve this problem?
I created an endpoint on the billing system side that receives user data, auction data, and status: #internetee/eis_billing_system#90. On the auction side, I created a service object that takes the necessary data and sends it to the auction.
How to check?
You need to check how different statuses are changed in the billing system when the administrator changes the deposit status in the auction.
How to review?