-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI changes to pause a channel #2373
Conversation
ismaelbej
commented
Oct 29, 2024
•
edited
Loading
edited
- Rename AddButton to ActionButton
- Allow icon and color props for ActionButton
- Add ChannelPause button
- Add actions to pause a channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll probably have to rebase or something before merging, but the changes are OK 👍
* Allow icon and color props for ActionButton * Add ChannelPause button * Add actions to pause a channel
Co-authored-by: Matías García Isaía <[email protected]>
111d8a7
to
ed424bc
Compare
@matiasgarciaisaia The actions pause/unpause triggers a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Since fetching the channel is enough for the UI to get updated (upon CHANNEL_RECEIVE
), we could trigger a new CHANNEL_FETCH
once per minute. I think the only part of the app that could have some feature like that is the sandbox, probably when using a real channel - maybe the simulation too?
Here's where the timer is set in the simulator's UI: surveda/assets/js/components/surveys/SurveySimulation.jsx Lines 45 to 49 in c82e6c0
|