Apply suggestions from code review

Co-authored-by: Matías García Isaía <[email protected]>
instedd · Oct 30, 2024 · 111d8a7 · 111d8a7
1 parent d157130
commit 111d8a7
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/assets/css/_global.scss b/assets/css/_global.scss
@@ -836,8 +836,8 @@ i.survey-status {
 .channel-paused {
   display: block;
   color: var(--reference-color12);
-  width: 12px;
-  height: 12px;
+  width: 24px;
+  height: 24px;
 }
 
 .wizard-content {

diff --git a/assets/js/components/channels/ChannelIndex.jsx b/assets/js/components/channels/ChannelIndex.jsx
@@ -229,7 +229,6 @@ class ChannelIndex extends Component<any> {
         </li>
       )
     }
-
     let providerUIs = []
     config.verboice.forEach((_, index) => {
       providerUIs.push(verboiceProviderUI(index, multipleVerboice))
@@ -297,7 +296,7 @@ class ChannelIndex extends Component<any> {
                 if (!channel)
                   return (
                     <tr key={-index} className="empty-row">
-                      <td colSpan="4" />
+                      <td colSpan="3" />
                     </tr>
                   )
 

diff --git a/assets/js/components/channels/ChannelPause.jsx b/assets/js/components/channels/ChannelPause.jsx
@@ -14,7 +14,6 @@ const ChannelPause = ({ channel, t, actions }) => {
   const color = paused ? "green" : "red"
 
   const pauseChannel = (channel, pause) => {
-    console.log(`About to ${pause ? "pause" : "unpause"} channel ${channel.id}`)
     if (pause) {
       actions.pause(channel.id)
     } else {

diff --git a/assets/js/components/channels/DownChannelsStatus.jsx b/assets/js/components/channels/DownChannelsStatus.jsx
@@ -13,7 +13,7 @@ class DownChannelsStatus extends PureComponent {
   render() {
     const { channels, timestamp } = this.props
     const channelNames = map(channels, (channel) => channel.name)
-    const paused = every(channels, (channel) => channel.statusInfo && channel.statusInfo.status == "paused")
+    const paused = every(channels, (channel) => channel.statusInfo?.status == "paused")
     const text = paused ? "paused" : "down"
     return this.downChannelsDescription(channelNames, timestamp, text)
   }