Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage (pt4). #391

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Conversation

Laimiux
Copy link
Collaborator

@Laimiux Laimiux commented Sep 17, 2024

No description provided.

@carrotkite
Copy link

carrotkite commented Sep 17, 2024

1 Warning
⚠️ No coverage data found for com/instacart/formula/android/events/FragmentLifecycleEvent

JaCoCo Code Coverage 96.95% ✅

Class Covered Meta Status
com/instacart/formula/android/ActivityConfigurator 100% 0%
com/instacart/formula/android/events/FragmentLifecycleEvent No coverage data found : -% No coverage data found : -% 🃏
com/instacart/formula/android/internal/AppManager 92% 0%
com/instacart/formula/android/internal/FormulaFragmentViewFactory 100% 0%
com/instacart/formula/android/internal/FragmentFlowRenderView 72% 0%
com/instacart/formula/android/internal/ActivityStoreFactory 100% 0%
com/instacart/formula/android/internal/FragmentLifecycle 75% 0%
com/instacart/formula/android/internal/FragmentStoreFormula 100% 0%

Generated by 🚫 Danger

@Laimiux Laimiux force-pushed the laimonas/increase-code-coverage-pt4 branch from d17a414 to 693dacd Compare September 17, 2024 12:48
@Laimiux Laimiux force-pushed the laimonas/increase-code-coverage-pt4 branch from 71e10ec to 3c42004 Compare September 17, 2024 14:31
@Laimiux Laimiux force-pushed the laimonas/increase-code-coverage-pt4 branch from 3c42004 to afa6462 Compare September 17, 2024 14:40
Copy link
Collaborator

@alexanderbezverhni alexanderbezverhni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

import org.junit.runner.RunWith

/**
* Tests that formula-android module handles non-bound activities gracefully.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: fragment activities?

@Laimiux Laimiux merged commit 1fda00f into master Sep 18, 2024
4 checks passed
@Laimiux Laimiux deleted the laimonas/increase-code-coverage-pt4 branch September 18, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants