More tests for formula-android.

instacart · Sep 17, 2024 · 71e10ec · 71e10ec
1 parent f4e4e33
commit 71e10ec
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/formula-android/src/main/java/com/instacart/formula/android/ActivityConfigurator.kt b/formula-android/src/main/java/com/instacart/formula/android/ActivityConfigurator.kt
@@ -8,7 +8,7 @@ import kotlin.reflect.KClass
  */
 class ActivityConfigurator {
     internal class Binding<A : FragmentActivity>(
-        val init: ActivityStoreContext<A>.() -> ActivityStore<A>?
+        val init: ActivityStoreContext<A>.() -> ActivityStore<A>
     )
 
     internal val bindings = mutableMapOf<KClass<*>, Binding<*>>()

diff --git a/formula-android/src/main/java/com/instacart/formula/android/internal/ActivityStoreFactory.kt b/formula-android/src/main/java/com/instacart/formula/android/internal/ActivityStoreFactory.kt
@@ -24,7 +24,7 @@ internal class ActivityStoreFactory internal constructor(
             ?: return null
 
         val activityDelegate = ActivityStoreContextImpl<A>()
-        return initializer.init.invoke(activityDelegate)?.let { store ->
+        return initializer.init.invoke(activityDelegate).let { store ->
             ActivityManager(
                 environment = environment,
                 delegate = activityDelegate,

diff --git a/formula-android/src/test/java/com/instacart/formula/android/ActivityStoreFactoryTest.kt b/formula-android/src/test/java/com/instacart/formula/android/ActivityStoreFactoryTest.kt
@@ -26,4 +26,14 @@ class ActivityStoreFactoryTest {
         val store = factory.init(mock<FakeActivity>())!!
         assertThat(store.stateSubscription.isDisposed).isFalse()
     }
+
+    @Test fun `returns null if no binding for activity is found`() {
+        val factory = ActivityStoreFactory(
+            environment = FragmentEnvironment(),
+            activities = {}
+        )
+
+        val store = factory.init(mock<FakeActivity>())
+        assertThat(store).isNull()
+    }
 }