Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

445 unify html tags #268

Merged
merged 3 commits into from
Mar 15, 2024
Merged

445 unify html tags #268

merged 3 commits into from
Mar 15, 2024

Conversation

kartikeyakirar
Copy link
Contributor

part of insightsengineering/teal.slice#445
for teal.goshawk package

Copy link
Contributor

github-actions bot commented Mar 7, 2024

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        359     359  0.00%    172-599
R/tm_g_gh_correlationplot.R                570     570  0.00%    222-900
R/tm_g_gh_density_distribution_plot.R      285     285  0.00%    134-470
R/tm_g_gh_lineplot.R                       576     576  0.00%    160-833
R/tm_g_gh_scatterplot.R                    252     252  0.00%    142-447
R/tm_g_gh_spaghettiplot.R                  304     304  0.00%    189-561
R/toggleable_slider.R                      154     154  0.00%    82-253
R/utils-arbitrary_lines.r                  125     125  0.00%    19-175
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    25-37
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   39      39  0.00%    12-83
R/zzz.R                                      1       1  0.00%    2
TOTAL                                     2935    2935  0.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 8700df9

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

averissimo
averissimo previously approved these changes Mar 15, 2024
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! 🎸

@averissimo averissimo dismissed their stale review March 15, 2024 08:32

Documentation

Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 Good to go with a caveat:

The documentation on {teal.widgets} changed, I've pushed the updated documentation.

However, if you feel this should not be in this PR, please revert my commit and merge.

@kartikeyakirar kartikeyakirar merged commit fe7fad6 into main Mar 15, 2024
23 checks passed
@kartikeyakirar kartikeyakirar deleted the 445_unify_tags branch March 15, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants