-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify use of tags$*
across the package
#445
Comments
The majority of common HTML tags are directly accessible through re-exports from the so for unifying I prefer to do prefix WDYT? |
It's probably the way to go. |
Good choice on the |
You can do that next month 😉 |
we can re-migrate every month : P |
part of insightsengineering/teal.slice#445 for teal.transform package
part of insightsengineering/teal.slice#445 for teal package --------- Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
part of insightsengineering/teal.slice#445 for teal.widget package --------- Co-authored-by: André Veríssimo <[email protected]>
part of insightsengineering/teal.slice#445 for teal.modules.hermes package Co-authored-by: André Veríssimo <[email protected]>
part of insightsengineering/teal.slice#445 for teal.goshawk package --------- Co-authored-by: André Veríssimo <[email protected]>
part of insightsengineering/teal.slice#445 for teal.osprey package --------- Co-authored-by: André Veríssimo <[email protected]>
part of insightsengineering/teal.slice#445 for teal.modules.general package --------- Co-authored-by: André Veríssimo <[email protected]> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
fixes #445 --------- Co-authored-by: André Veríssimo <[email protected]>
part of insightsengineering/teal.slice#445 for teal.modules.clinical package --------- Co-authored-by: André Veríssimo <[email protected]>
shiny
functions that createHTML
tags (re-exported fromhtmltools
) can be used directly or as elements of thetags
list:In
teal.slice
mostdiv
calls are direct butspan
calls usually usetags$
.Pick one and apply throughout the package.
similar changes done here as part of this PR
The text was updated successfully, but these errors were encountered: