Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estimate densities from point patterns #27

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

estimate densities from point patterns #27

wants to merge 14 commits into from

Conversation

ThierryO
Copy link
Contributor

@stijnvanhoey can you render this? I can't render the SQL tutorial.

@florisvdh
Copy link
Member

Some work to get this tutorial in the right directory structure has been done in the density_fv branch. Fixing CRS specification will folllow later.

The use of 'proj4string' in R code is confusing in times where PROJ.4 strings are obsoleted.
It can be expected that a more general function name to set an object's CRS will sooner or later
be promoted instead of proj4string<-, hence preparing for that already by using the function instead of the slot.
I expect the proj4string slot will most probably remain in use for compatibility reasons, but
explicitly naming it is better avoided in times where WKT2 strings are actually used to define a CRS.
Copy link
Member

@florisvdh florisvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThierryO In PR #195 I suggest some changes to get in line with the current tutorials (folder setup, CRS).

Please note:

  • index.md is still to be regenerated - reason: see next point. YAML header in Rmd has been updated already in 'estimate densities from point patterns': PROJ>=6 compliance #195 .
  • the ggmap code with google map will need to be revised. Current code cannot be run (hence, index.md cannot be updated) except when getting a personal API from google and handing your credit card details (and it's free just for a limited period). Not fit for a tutorial anymore IMHO. Maybe you will now rather prefer using OSM.

'estimate densities from point patterns': PROJ>=6 compliance
@florisvdh
Copy link
Member

@ThierryO In PR #195 I suggest some changes to get in line with the current tutorials (folder setup, CRS).

Please note:

  • index.md is still to be regenerated - reason: see next point. YAML header in Rmd has been updated already in 'estimate densities from point patterns': PROJ>=6 compliance #195 .

  • the ggmap code with google map will need to be revised. Current code cannot be run (hence, index.md cannot be updated) except when getting a personal API from google and handing your credit card details (and it's free just for a limited period). Not fit for a tutorial anymore IMHO. Maybe you will now rather prefer using OSM.

Follow-up: PR #195 has now been merged into this PR. @ThierryO the above notes still need some work before it can be merged in master and this long-standing but nice tutorial will be merged.

@ThierryO
Copy link
Contributor Author

Sorry. This has very low priority to me. Feel free to update the code.

@florisvdh
Copy link
Member

@inbo/bmk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants