'estimate densities from point patterns': PROJ>=6 compliance #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of 'proj4string' in R code is confusing in times where PROJ.4 strings are obsoleted. It can be expected that a more general function name to set an object's CRS will sooner or later be promoted instead of proj4string<-, hence preparing for that already by using the function instead of the slot. I expect the proj4string slot will most probably remain in use for compatibility reasons, but explicitly naming it is better avoided in times where WKT2 strings are actually used to define a CRS.
florisvdh
changed the title
ThierryO
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amends PR #27