-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ImageJ2/Fiji version in the docs and improve toc layout #276
Conversation
afcdccd
to
7c99ee1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elevans I like all of the changes - in fact, most of my comments probably aren't related to your changes.
One final question - can you build the documentation? I ran make docs && firefox doc/_build/html/index.html
, but it errors.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=======================================
Coverage 77.60% 77.60%
=======================================
Files 16 16
Lines 1947 1947
=======================================
Hits 1511 1511
Misses 436 436 ☔ View full report in Codecov by Sentry. |
83b3795
to
746af2e
Compare
I think this might be confusing for people and might generate erroneous bug reports. If someone sees our notebooks with the clean output but theirs is duplicating they might reach out to us. |
Sphinx doesn't like "!pip" with a python language code block.
The blood vessel image is no longer available. This commit swaps the blood vessel image with a slice from a 4D dataset that contains microtubules in metaphase.
Re-run all jupyter notebooks and save their output with ImageJ2 version 2.13.1.
This commit reorganizes the table of contents for the read the docs site. I added sections and emojis to enhance readability and create a more welcoming experince for visitors.
NumPy arrays go to `net.imagej.DefaultDataset` and don't make an `ImgView`.
I accidentally ran the notebook without itkwidgets and pushed the output.
The output was only displaying the first cell. I also fixed the column names. Pandas thought it was a multi-level column name.
We fixed a duplicating stdout and stderr in commit d99fcf0 thus we need to recreate the notebook outputs.
411250b
to
c5214a0
Compare
I wasn't able to reproduce this. This command works fine on my end. I did |
This PR is in response to #271 and updates the version of ImageJ2/Fiji we use from
2.5.0
to2.13.1
. I also applied the following changes:03-Sending-Data-to-Java
with a slice of microtubules from a HeLa cell in metaphase that I took a few years back.