Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in the Use cases"Classic Segmentation: Segmentation workflow with original ImageJ functions" in PyImageJ’s documentation #282

Closed
mol666 opened this issue Aug 3, 2023 · 3 comments

Comments

@mol666
Copy link

mol666 commented Aug 3, 2023

There are 32 cells detected, however the output has 32 group of datas which are completely same. They are just the measurements of the first cell.
This line of code:
for column in results.getHeadings(): stats_ij[column].append(results.getColumn(column)[0])
should be modified to be:
stats_ij[column].append(results.getColumn(column)[-1])
as the index while appending should be corrected.

Hope some notice.

@elevans
Copy link
Member

elevans commented Aug 3, 2023

Hi @mol666, thanks for pointing this out! You are correct, we had the wrong output here. I'm pretty close to finishing a PR that will bring some updates to the documentation (either today or tomorrow). I will be sure to include this into #276. For now I'll keep this issue open until I get that merged into main.

@mol666
Copy link
Author

mol666 commented Aug 4, 2023

That's great! PyimageJ and what you developers do help me a lot. Sincere thanks to you!

@elevans
Copy link
Member

elevans commented Aug 10, 2023

This fix as been merged into main: e50446e.

@elevans elevans closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants