Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andd54/independent watchdog #68

Merged
merged 20 commits into from
Dec 30, 2023
Merged

Andd54/independent watchdog #68

merged 20 commits into from
Dec 30, 2023

Conversation

Andd54
Copy link
Member

@Andd54 Andd54 commented Dec 26, 2023

independent watchdog completed and fundamental trigger for hardware reset is completed. Now able to detect basic can connection errors after the timeout.

Copy link
Member

@AzulRadio AzulRadio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure LGTM.

examples/iwdg/CMakeLists.txt Outdated Show resolved Hide resolved
examples/iwdg/CMakeLists.txt Outdated Show resolved Hide resolved
examples/iwdg/main.cc Show resolved Hide resolved
vehicles/Fortress/main.cc Outdated Show resolved Hide resolved
vehicles/Steering/chassis.cc Outdated Show resolved Hide resolved
vehicles/Steering/chassis.cc Outdated Show resolved Hide resolved
vehicles/Steering/gimbal.cc Outdated Show resolved Hide resolved
@Andd54 Andd54 removed the request for review from neilghose1 December 30, 2023 03:30
Copy link
Member

@AzulRadio AzulRadio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would name the example folder watchdog/ instead of iwdg/ but that depends on you. Great job as always

SOURCES main.cc
)

irm_add_arm_executable(${PROJECT_NAME}_C
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
irm_add_arm_executable(${PROJECT_NAME}_C
irm_add_arm_executable(${PROJECT_NAME}_typeC

}
}

//==================================================================================================
// Gimbal
//==================================================================================================

const osThreadAttr_t gimbalTaskAttribute = {.name = "gimbalTask",
const osThreadAttr_t rmgimbalTaskAttribute = {.name = "gimbalTask",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const osThreadAttr_t rmgimbalTaskAttribute = {.name = "gimbalTask",
const osThreadAttr_t rmGimbalTaskAttribute = {.name = "gimbalTask",

@@ -634,23 +656,26 @@ static bsp::BuzzerNoteDelayed Mario[] = {
static bsp::Buzzer* buzzer = nullptr;
static display::OLED* OLED = nullptr;
//simple bitmask function for chassis flag

#define BITMAP_SUMMARY 0b11111111 // expected bit map for chassis motors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define BITMAP_SUMMARY 0b11111111 // expected bit map for chassis motors
#define BITMAP_SUMMARY 0xFF // expected bit map for chassis motors

send = new bsp::CanBridge(can2, 0x20A, 0x20B);
}

void RM_RTOS_Threads_Init(void) {
imuTaskHandle = osThreadNew(imuTask, nullptr, &imuTaskAttribute);
gimbalTaskHandle = osThreadNew(gimbalTask, nullptr, &gimbalTaskAttribute);
gimbalTaskHandle = osThreadNew(gimbalTask, nullptr, &rmgimbalTaskAttribute);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gimbalTaskHandle = osThreadNew(gimbalTask, nullptr, &rmgimbalTaskAttribute);
gimbalTaskHandle = osThreadNew(gimbalTask, nullptr, &rmGimbalTaskAttribute);

@Andd54 Andd54 merged commit 5853850 into main Dec 30, 2023
1 check passed
Andd54 added a commit that referenced this pull request Feb 12, 2024
Andd54 added a commit that referenced this pull request Feb 12, 2024
AzulRadio added a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants