-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minipc protocol 2.0 #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerQi
reviewed
Nov 23, 2023
examples/autoaim/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why commented out
rickxu2
reviewed
Dec 23, 2023
rickxu2
reviewed
Dec 26, 2023
rickxu2
approved these changes
Dec 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some tests and LGTM, except minor change needed on the vision repo (waiting for permission to push).
Andd54
pushed a commit
that referenced
this pull request
Feb 11, 2024
* Break Send() into Pack() for each message type * add function headers and helpers for Pack() * lossless float transmission * data parse rewrite * rename autoaim_protocol as minipc_protocol; add more comments. * add examples --------- Co-authored-by: Richard Xu <[email protected]>
Andd54
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Break Send() into Pack() for each message type * add function headers and helpers for Pack() * lossless float transmission * data parse rewrite * rename autoaim_protocol as minipc_protocol; add more comments. * add examples --------- Co-authored-by: Richard Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Minipc - Stm32 uart protocol.
Major feature:
Minor changes:
Note that the communication should always be single-sided. A response should never directly depend on any data in previous packets. Example: send back
rel_pitch += 1
is an undefined behavior. (Yes, this is the pingpong test.)Protocol details:
See document:
docs/comm_protocol.md
in illini-robomaster/iRM_Vision_2023#16To test this:
Embedded repo
example/minipc/StressTestTypeC.cc
with Vision repoCommunication/communicator.py
and
Embedded repo
example/minipc/PingpongTest.cc
with Vision repoCommunication/communicator.py
For testing details and config setup see code comments.
Embedded PR: #66
Vision PR: illini-robomaster/iRM_Vision_2023#16
Todo: