Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New interpolation schemes, modified filtering, and added tests #79

Merged
merged 44 commits into from
Dec 5, 2023

Conversation

orebas
Copy link
Collaborator

@orebas orebas commented Dec 5, 2023

This PR combines a few new features, and is definitely a breaking change.

  1. Instead of iterating over different degree of rational interpolant, the Trefethen-Nakatsukasa AAA algorithm is used to find one good interpolant (ideally of lowest reasonable degree.) Also added are Floater Hormann interpolation and a simple Fourier based interpolation.
  2. Added a precompile workload, so the precompile step is much longer but "Using ParameterEstimation" is about 4x faster on my computer.
  3. Added a number of parameter recovery tests, hope to add more in the future.
  4. Changed the filtering scheme; now all potentially reasonable sets of parameters are returned, however;
  5. Added support for filtering out parameter and initial conditions outside of a constraint set.
  6. A small number of bug fixes here and there.

orebas and others added 30 commits July 30, 2023 14:30
… refactor which makes each of interpolation,polynomial solving, and constraint selection more modular
Gets reasonable results for simple.jl, coupled pendulum.
Clearly wrong for lotkta-volterra.
@iliailmer iliailmer merged commit c16d3a4 into iliailmer:main Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants