Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bar Charts with larger scales have wider margins #331

Merged
merged 7 commits into from
Aug 1, 2023
Merged

Bar Charts with larger scales have wider margins #331

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dc8f1a6
Charts with 4 digit scales have wider margins
KevinWu098 Jul 20, 2023
48f90ef
Moved global var largeGraphScale into render
KevinWu098 Jul 20, 2023
33deec2
Update site/src/component/GradeDist/Chart.tsx
KevinWu098 Jul 27, 2023
929fa9c
Added a return type to getClassData() & type casting grade[grade.id]
KevinWu098 Jul 28, 2023
ecbd71b
Check the magnitude of the graph for dynamic margins
KevinWu098 Jul 28, 2023
cfc8db6
Minor update to comment
KevinWu098 Jul 28, 2023
4afbfaf
Merge branch 'master' into scaleFourDigit
KevinWu098 Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions site/src/component/GradeDist/Chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,16 +131,19 @@ export default class Chart extends React.Component<ChartProps> {
* @return a JSX block rendering the chart
*/
render() {
const data = this.getClassData()
const largeGraphScale = data.some((grade) => Object.values(grade).some((value) => value > 999));
KevinWu098 marked this conversation as resolved.
Show resolved Hide resolved

return <>
<ResponsiveBar
data={this.getClassData()}
data={data}
keys={['A', 'B', 'C', 'D', 'F', 'P', 'NP']}
indexBy='label'
margin={{
top: 50,
right: 30,
right: largeGraphScale ? 35: 30,
bottom: 50,
left: 30
left: largeGraphScale ? 35: 30,
}}
layout='vertical'
axisBottom={{
Expand Down