Bar Charts with larger scales have wider margins #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this.classData()
is set to a new constdata
so thatlargeGraphScale
can access the array without recallingthis.classData()
greatestCount
to find the largest grade value within datamarginX
which calculates margins depending on the magnitude of greatestCount, with every magnitude above 100 increasing the base margin (30) by 5. For example, 5173 would set marginX to 35, while 123 would set it to 30.More detailed documentation is in code comments!
Screenshots
Before:
After:
Steps to verify/test this change:
Final Checks:
Closes #296