Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(download.ts): add location attribute to custom events #1004

Merged
merged 1 commit into from
Oct 1, 2024

Commits on Sep 17, 2024

  1. feat(download.ts): add location attribute to custom events

    I noticed a TODO asking to implement a location for custom events
    once icssc#249 was finished. I noticed that the issue was completed so
    I went ahead and implemented it.
    
    Though... it looks a bit funky because CustomEvent.building saves
    an ID instead of the actual building name. This happens in
    CustomEventDialog.tsx because it needs a key for the list that's
    needed in BuildingSelect. Though I noticed that BuildingSelect
    gets the name of the building using the format I used here.
    calejvaldez committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f6c8179 View commit details
    Browse the repository at this point in the history