feat(download.ts): add location attribute to custom events #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed a TODO asking to implement a location for custom events once icssc#249 was finished. I noticed that the issue was completed so I went ahead and implemented it. Though... it looks a bit funky because CustomEvent.building saves an ID instead of the actual building name. This happens in CustomEventDialog.tsx because it needs a key for the list that's needed in BuildingSelect. Though I noticed that BuildingSelect gets the name of the building using the format I used here.
MinhxNguyen7
requested review from
MinhxNguyen7
and removed request for
KevinWu098
MinhxNguyen7
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed a TODO asking to implement a location for custom events once #249 was finished. I noticed that the issue was completed so I went ahead and implemented it.
Though... it looks a bit funky because
CustomEvent.buildingsaves an ID instead of the actual building name. This happens inCustomEventDialog.tsxbecause it needs a key for the list that's needed inBuildingSelect. Though I noticed thatBuildingSelectgets the name of the building using the format I used here.Test Plan
I tested this by creating a custom event and downloading a
.ics. I then imported it to Google Calendar and saw that the location of the event was successfully added.Issues
N/A, but addresses this line in the code:
AntAlmanac/apps/antalmanac/src/lib/download.ts
Lines 278 to 279 in 559b615
Future Follow-Up