[WIP][Feature] Implement map action for dynamic kick #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplement-map-action-for-dynamic-kick
…mplement-map-action-for-dynamic-kick
…mplement-map-action-for-dynamic-kick
hiikariri
changed the title
threeal
requested changes
Jun 23, 2024
| std::string name = ""; | ||
| std::string file_name = entry.path(); | ||
| std::string extension_json = ".json"; | ||
| for (int i = path.length(); i < file_name.length() - extension_json.length(); i++) { | ||
| for (int i = (path + action_dir).length(); i < file_name.length() - extension_json.length(); i++) { |
There was a problem hiding this comment.
Ditto:
Suggested change
| for (int i = (path + action_dir).length(); i < file_name.length() - extension_json.length(); i++) { | |
| for (int i = (path + action_dir).length(); i < file_name.length() - extension_json.length(); ++i) { |
Comment on lines
108
to
109
| for (auto &[key, val] : json.items()) { | ||
| if (key == "dynamic_kick") { |
There was a problem hiding this comment.
Should use nlohmann::json::find instead of for-looping the items.
…mplement-map-action-for-dynamic-kick
…b.com:ichiro-its/akushon into feature/implement-map-action-for-dynamic-kick
threeal
reviewed
Jun 25, 2024
…mplement-map-action-for-dynamic-kick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link:
Description
Change the workflow to start an action. When wide kick action is detected, the value of the joint is mapped between normal and wide kick based on the ball x position in the camera. There is also a change to load config and save config, because the structure of
actionfolder is now:action
Work is still in progress.
Type of Change
How Has This Been Tested?
Checklist:
feature/JIRA-ID-SHORT-DESCRIPTIONif has a JIRA ticketenhancement/SHORT-DESCRIPTIONif has/has no JIRA ticket and contain enhancementhotfix/SHORT-DESCRIPTIONif the change doesn't need to be tested (urgent)