Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#709 fix custom baseName for apple framework #713

Merged
merged 3 commits into from
May 21, 2024

Conversation

Alex009
Copy link
Member

@Alex009 Alex009 commented May 18, 2024

No description provided.

@Alex009 Alex009 added this to the 0.24.0 milestone May 18, 2024
@Alex009 Alex009 self-assigned this May 18, 2024
@Alex009 Alex009 linked an issue May 18, 2024 that may be closed by this pull request
@ExNDY
Copy link
Contributor

ExNDY commented May 20, 2024

@Alex009

Hi, we again has problem with xcodebuild configuration in local-check.sh. When we use:

    xcodebuild -scheme iosApp -workspace iosApp.xcworkspace -configuration Debug -destination "generic/platform=iOS Simulator" build CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO

xcode build FatFramework, but us configuration do nothing for this.
If i'm rollback on configuration on:

    xcodebuild -scheme iosApp -workspace iosApp.xcworkspace -configuration Debug -sdk iphonesimulator -arch x86_64 build CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO

We get correct compile and check with SharedKit.framework

@Alex009
Copy link
Member Author

Alex009 commented May 21, 2024

@ExNDY but in clean sample without resources - it works correctly https://github.com/Alex009/test-fat-framework

@Alex009 Alex009 merged commit 6ed5168 into develop May 21, 2024
29 checks passed
@Alex009 Alex009 deleted the #709-fix-custom-baseName branch May 21, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggested improvements to CopyFrameworkResourcesToAppTask
2 participants