Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested improvements to CopyFrameworkResourcesToAppTask #709

Closed
syxc opened this issue May 16, 2024 Discussed in #701 · 1 comment · Fixed by #713
Closed

Suggested improvements to CopyFrameworkResourcesToAppTask #709

syxc opened this issue May 16, 2024 Discussed in #701 · 1 comment · Fixed by #713
Assignees
Labels
bug Something isn't working
Milestone

Comments

@syxc
Copy link

syxc commented May 16, 2024

Discussed in #701

Originally posted by syxc May 10, 2024
CopyFrameworkResourcesToAppTask is not well designed, if the baseName of the iOS framework in the shared module of KMP is not the same as it is, something will go wrong, e.g.

KMP shared project shared

├── LICENSE
├── README.md
├── build.gradle.kts
├── gradle
├── gradle.properties
├── gradlew
├── gradlew.bat
├── androidApp
├── iosApp
├── shared
└── settings.gradle.kts
cocoapods {
  summary = "Some description for the Shared Module"
  homepage = "Link to the Shared Module homepage"
  version = "1.0"
  ios.deploymentTarget = "13.0"
  framework {
    baseName = "SharedKit"
    binaryOptions["bundleId"] = "com.github.app.shared"
    isStatic = true
    export(moko.resources)
    export("dev.icerock.moko:graphics:0.9.0")
  }
  podfile = project.file("../iosApp/Podfile")
}

You guys can go ahead and try it out, you can see this kind of problem I'm getting feedback on when Moko executes the script in Xcode.

@Alex009 Alex009 added the bug Something isn't working label May 16, 2024
@Alex009 Alex009 added this to the 0.24.0 milestone May 16, 2024
@Alex009 Alex009 linked a pull request May 18, 2024 that will close this issue
Alex009 added a commit that referenced this issue May 21, 2024
@Alex009
Copy link
Member

Alex009 commented May 21, 2024

Will be released in 0.24.0-beta-5

@Alex009 Alex009 closed this as completed May 22, 2024
@Alex009 Alex009 mentioned this issue Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants