issue1878 mover model warnings #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwetter
approved these changes
May 14, 2024
There was a problem hiding this comment.
@hcasperfu : Looks good to me. Please also assign a non-LBL reviewer.
|
@Mathadon - Greetings! Can you please review this PR? |
4 tasks
Mathadon
approved these changes
May 14, 2024
hcasperfu
added a commit
that referenced
this pull request
May 14, 2024
|
@mwetter Can you please restart https://app.travis-ci.com/github/ibpsa/modelica-ibpsa/jobs/621688611 ? This is an unrelated fail. |
|
@hcasperfu Just restarted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1878.
This PR merges changes made in lbl-srg/modelica-buildings#3830 that are applicable to IBPSA.