You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Referred in #1879.
This issue is to address the two following items:
There is an error in Fluid.Movers.BaseClasses.FlowMachineInterface. If the provided power curve refers to total power instead of hydraulic power (powerOrEfficiencyIsHydraulic=false), the motor efficiency $\eta_{mot}$ would be accounted for twice because of mistakes in equations. This configuration is rarely used in Buildings. Throughout the Buildings library, this error only affected results of Fluid.Movers.Validation.{PowerEuler,PowerExact,PowerSimplified}.
There is an error in Fluid.Movers.Validation.{PowerEuler,PowerExact}. The efficiency values were assigned incorrectly. These two models were intended to demonstrate how the speed-controlled model and the flow-controlled models estimate power differently. However, there is no longer such difference once the efficiency assignments are corrected. After some email exchanges with @Mathadon, we think various refactoring over the years may have fixed the limitation these models tried to show.
These two are combined in the same ticket because they affect the same validation models.
Action items:
Correct errors in the efficiency computation of Fluid.Movers.BaseClasses.FlowMachineInterface.
Referred in #1879.
This issue is to address the two following items:
Fluid.Movers.BaseClasses.FlowMachineInterface
. If the provided power curve refers to total power instead of hydraulic power (powerOrEfficiencyIsHydraulic=false
), the motor efficiencyFluid.Movers.Validation.{PowerEuler,PowerExact,PowerSimplified}
.Fluid.Movers.Validation.{PowerEuler,PowerExact}
. The efficiency values were assigned incorrectly. These two models were intended to demonstrate how the speed-controlled model and the flow-controlled models estimate power differently. However, there is no longer such difference once the efficiency assignments are corrected. After some email exchanges with @Mathadon, we think various refactoring over the years may have fixed the limitation these models tried to show.These two are combined in the same ticket because they affect the same validation models.
Action items:
Fluid.Movers.BaseClasses.FlowMachineInterface
.Fluid.Movers.Validation.{PowerEuler,PowerExact,PowerSimplified}
.The text was updated successfully, but these errors were encountered: