Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct mover efficiency in unusual configuration and rework validation models #1880

Closed
4 tasks done
hcasperfu opened this issue May 14, 2024 · 0 comments · Fixed by #1881
Closed
4 tasks done

Correct mover efficiency in unusual configuration and rework validation models #1880

hcasperfu opened this issue May 14, 2024 · 0 comments · Fixed by #1881
Assignees

Comments

@hcasperfu
Copy link
Contributor

hcasperfu commented May 14, 2024

Referred in #1879.
This issue is to address the two following items:

  • There is an error in Fluid.Movers.BaseClasses.FlowMachineInterface. If the provided power curve refers to total power instead of hydraulic power (powerOrEfficiencyIsHydraulic=false), the motor efficiency $\eta_{mot}$ would be accounted for twice because of mistakes in equations. This configuration is rarely used in Buildings. Throughout the Buildings library, this error only affected results of Fluid.Movers.Validation.{PowerEuler,PowerExact,PowerSimplified}.
  • There is an error in Fluid.Movers.Validation.{PowerEuler,PowerExact}. The efficiency values were assigned incorrectly. These two models were intended to demonstrate how the speed-controlled model and the flow-controlled models estimate power differently. However, there is no longer such difference once the efficiency assignments are corrected. After some email exchanges with @Mathadon, we think various refactoring over the years may have fixed the limitation these models tried to show.

These two are combined in the same ticket because they affect the same validation models.

Action items:

  • Correct errors in the efficiency computation of Fluid.Movers.BaseClasses.FlowMachineInterface.
  • Obsolete Fluid.Movers.Validation.{PowerEuler,PowerExact,PowerSimplified}.
  • Make a new validation model to demonstrate the difference of power estimation methods of the current version.
  • Make a new validation model to validate the efficiency computation that is corrected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant