Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short cycling in air-to-water HP example #1877

Merged
merged 12 commits into from
May 17, 2024
Merged

Short cycling in air-to-water HP example #1877

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f4fac7b
group safety control parameters according to dialog enable
FWuellhorst May 13, 2024
1bb7734
add name to contributor list
FWuellhorst May 13, 2024
b4fd3e8
Change over- to undersizing and update documentation of the example
FWuellhorst May 13, 2024
23166ae
remove scaling warning and enable minimal off time as usual in heat p…
FWuellhorst May 15, 2024
a193f88
use better start value, full path
FWuellhorst May 15, 2024
2de18c2
Specify mover data in all examples to avoid warnings
FWuellhorst May 15, 2024
8e28bb4
Reformatted files
mwetter May 15, 2024
ee37aea
update conservative default to 1 %
FWuellhorst May 15, 2024
e7c2d92
make movers replaceable, use preconfigured movers in all but LargeSca…
FWuellhorst May 16, 2024
373f68c
remove replaceable again, as preconfigured models work without the sc…
FWuellhorst May 16, 2024
9d3395c
Adjust LargeScaleWaterToWater_OneRoomRadiator.mo example to trigger c…
FWuellhorst May 16, 2024
77387b7
update reference results
FWuellhorst May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions IBPSA/Fluid/HeatPumps/ModularReversible/Controls/Safety/Data/Generic.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ record Generic "Generic record definition for safety control blocks"
parameter Modelica.Units.SI.Time minOnTime
"Mimimum on-time" annotation (Dialog(group=
"On/Off Control", enable=use_minOnTime));
parameter Real ySetRed(unit="1")
"Reduced relative compressor speed to allow longer on-time"
annotation (
Dialog(group="On/Off Control",
enable=use_minOnTime));
parameter Boolean use_minOffTime
"=false to ignore minimum off time"
annotation (Dialog(group="On/Off Control"),
Expand All @@ -21,11 +26,7 @@ record Generic "Generic record definition for safety control blocks"
parameter Integer maxCycRat "Maximum cycle rate"
annotation (Dialog(group="On/Off Control",
enable=use_maxCycRat));
parameter Real ySetRed(unit="1")
"Reduced relative compressor speed to allow longer on-time"
annotation (
Dialog(group="On/Off Control",
enable=use_minOnTime));

parameter Boolean onOffMea_start=true
"Start value for the on-off signal of the device, true for on"
annotation (
Expand Down
17 changes: 16 additions & 1 deletion IBPSA/Fluid/HeatPumps/ModularReversible/Examples/AirToWater2D_OneRoomRadiator.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ model AirToWater2D_OneRoomRadiator
dpCon_nominal(displayUnit="Pa") = 2000,
dpEva_nominal(displayUnit="Pa") = 200,
energyDynamics=Modelica.Fluid.Types.Dynamics.FixedInitial,
QCoo_flow_nominal=-20000,
QCoo_flow_nominal=-10000,
TConHea_nominal=rad.TRad_nominal,
TEvaHea_nominal=283.15,
TConCoo_nominal=oneRooRadHeaPumCtr.TRadMinSup,
Expand Down Expand Up @@ -87,6 +87,16 @@ equation
heat pump model. Please check the associated documentation for
further information.
</p>
<p>
Furthermore, this example is useful to understand the different sizing options.
The selected value of <code>QCoo_flow_nominal</code> leads to
conflicting scaling factors for heating and cooling operation. This triggers a warning.
Using the default <code>QCoo_flow_nominal</code>, the warning disappears.
Increasing (or decreasing) it, the number of on-off switches will increase (or decrease)
in cooling operation due to the low inertia of the system.
In real air-to-water systems, thermal energy storage would be used to
decrease cycling if the device is oversized.
</p>
mwetter marked this conversation as resolved.
Show resolved Hide resolved
<p>
Please check the documentation of
<a href=\"modelica://IBPSA.Fluid.HeatPumps.ModularReversible.Examples.BaseClasses.PartialOneRoomRadiator\">
Expand All @@ -95,6 +105,11 @@ equation
</p>
</html>", revisions="<html>
<ul>
<li>
<i>May 5, 2024</i> by Fabian Wuellhorst:<br/>
Updated documentation and changed default value (see issue <a href=
\"https://github.com/ibpsa/modelica-ibpsa/issues/1876\">#1576</a>)
</li>
<li>
<i>October 2, 2022</i> by Fabian Wuellhorst:<br/>
First implementation (see issue <a href=
Expand Down
3 changes: 3 additions & 0 deletions IBPSA/package.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,9 @@ Kathryn Hinkelman, University of Colorado Boulder, USA
<li>
Michael Wetter, Lawrence Berkeley National Laboratory, Berkeley, CA, USA
</li>
<li>
Fabian Wuellhorst, RWTH Aachen University, Germany
</li>
</ul>
</html>"));
end Acknowledgements;
Expand Down
Loading