Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short cycling in air-to-water HP example #1877

Merged
merged 12 commits into from
May 17, 2024
Merged

Conversation

FWuellhorst
Copy link
Contributor

Closes #1876.

I also changed the grouping of the safety control to match the enable clause and added my name to the contributors list, is that ok?

@FWuellhorst FWuellhorst requested a review from mwetter May 13, 2024 08:30
Copy link
Contributor

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comment.
And thanks for adding your name to the contributor list, it certainly should be there.

@FWuellhorst
Copy link
Contributor Author

@mwetter I also added mover data to all examples to avoid the warnings raised by the movers.
@hcasperfu : I also tried using the preconfigured models as suggested in the warning, but get the warning
image
which will lead to CI failure. Dynamics are set to SteadyState, FixedInitial does not change this. Do you have a guess why this happens?

Copy link
Contributor

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment about perHeaLos being what I think is unreasonably large.

@hcasperfu
Copy link
Contributor

@FWuellhorst - The warning should be suppressed by 86f73be.
To clarify, this warning did not cause CI to fail. But since we have been working on managing the warning messages produced by mover models (#1878), this report is welcome.

@FWuellhorst
Copy link
Contributor Author

@hcasperfu : Ok, I opted to use the preconfigured models in the examples in this case and changed the dp_nominal to the fitting values of the heat pump, which was previously not the case.
For the LargeScaleWaterToWater example, I get the following error in OpenModelica:

[1] 08:33:44 Übersetzung Fehler
[IBPSA.Fluid.Movers.BaseClasses.Characteristics.efficiencyParameters_yMot: 5:3-6:45]: [Failed to evaluate function: Modelica.Blocks.Types.ExternalCombiTable2D.constructor.](omeditmessagesbrowser:///IBPSA.Fluid.Movers.BaseClasses.Characteristics.efficiencyParameters_yMot?lineNumber=5)

[2] 08:33:44 Übersetzung Fehler
[C:/OM122/OM64bit/OMCompiler/Compiler/NFFrontEnd/NFCeval.mo: 1494:9-1494:67]: Internal error NFCeval.evalLogicBinaryAnd failed to evaluate ‘true and sum(pumHeaPum.per.pressure.dp) > Modelica.Constants.eps‘

When I change the dp_nominal in the movers to a fixed value, e.g. 150000 (roughly the output of heaPum.dpEva_nominal), the model simulates. My guess is that the combination of the preconfigured models and the non-literal scaling factors lead to this error.

I will keep the 150000 for now and check after your mover updates if the error persists. If so, I will raise it to OM.

@FWuellhorst
Copy link
Contributor Author

@mwetter : I changed the movers and also the LargeScaleWaterToWater example as the cooling operation was previsously not triggered. To avoid cycling in this example as well, I adjusted the sizing and updated the documentation.

@mwetter mwetter merged commit d06feb4 into master May 17, 2024
3 checks passed
@mwetter mwetter deleted the issue1876_airtowaterHPexample branch May 17, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Short-cycling in heat pump example
3 participants