-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Short cycling in air-to-water HP example #1877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see inline comment.
And thanks for adding your name to the contributor list, it certainly should be there.
IBPSA/Fluid/HeatPumps/ModularReversible/Examples/AirToWater2D_OneRoomRadiator.mo
Outdated
Show resolved
Hide resolved
@mwetter I also added mover data to all examples to avoid the warnings raised by the movers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment about perHeaLos
being what I think is unreasonably large.
IBPSA/Fluid/HeatPumps/ModularReversible/Examples/CarnotWithLosses_OneRoomRadiator.mo
Outdated
Show resolved
Hide resolved
@FWuellhorst - The warning should be suppressed by 86f73be. |
…leWaterToWater_OneRoomRadiator.mo, add better dp_nominal
…ooling operation and change sizing for better cooling operation
@hcasperfu : Ok, I opted to use the preconfigured models in the examples in this case and changed the dp_nominal to the fitting values of the heat pump, which was previously not the case.
When I change the I will keep the 150000 for now and check after your mover updates if the error persists. If so, I will raise it to OM. |
@mwetter : I changed the movers and also the LargeScaleWaterToWater example as the cooling operation was previsously not triggered. To avoid cycling in this example as well, I adjusted the sizing and updated the documentation. |
Closes #1876.
I also changed the grouping of the safety control to match the enable clause and added my name to the contributors list, is that ok?