Merge pull request #1943 from ibpsa/issue1942_electricalInitialization

Changed default initialization of electrical load
ibpsa · Dec 16, 2024 · eff0f21 · eff0f21
2 parents 87ce6b5 + a202574
commit eff0f21
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/IBPSA/Electrical/Interfaces/Load.mo b/IBPSA/Electrical/Interfaces/Load.mo
@@ -22,7 +22,7 @@ model Load "Partial model for a generic load"
            or linearized)));
   parameter IBPSA.Electrical.Types.InitMode initMode(
   min=IBPSA.Electrical.Types.InitMode.zero_current,
-  max=IBPSA.Electrical.Types.InitMode.linearized) = IBPSA.Electrical.Types.InitMode.zero_current
+  max=IBPSA.Electrical.Types.InitMode.linearized) = IBPSA.Electrical.Types.InitMode.linearized
     "Initialization mode for homotopy operator"  annotation(Dialog(tab = "Initialization"));
 
   Modelica.Units.SI.Voltage v[:](start=PhaseSystem.phaseVoltages(V_nominal)) =
@@ -113,6 +113,13 @@ equation
   annotation ( Documentation(revisions="<html>
 <ul>
 <li>
+November 14, 2024, by Michael Wetter:<br/>
+Changed default initialization method to using linearized model rather than zero current, as
+the latter causes a division by zero in OpenModelica during the homotopy initialization.<br/>
+This is for
+<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4048\">Buildings, #4048</a>.
+</li>
+<li>
 January 30, 2019, by Michael Wetter:<br/>
 Set start value for <code>P</code>.
 </li>

diff --git a/IBPSA/Resources/Scripts/BuildingsPy/conf.yml b/IBPSA/Resources/Scripts/BuildingsPy/conf.yml
@@ -30,10 +30,6 @@
   openmodelica:
     comment: simulation terminated by an assertion at initialization.
     simulate: false
-- model_name: IBPSA.Electrical.DC.Loads.Examples.LinearizedLoad
-  openmodelica:
-    comment: '''omc'' caused ''simulation terminated by an assertion at initialization''.'
-    simulate: false
 - model_name: IBPSA.Fluid.Examples.FlowSystem.Basic
   openmodelica:
     comment: '''omc'' caused ''simulation terminated by an assertion at initialization''.'