Skip to content

Commit

Permalink
Changed default initialization
Browse files Browse the repository at this point in the history
For #1942
  • Loading branch information
mwetter committed Nov 14, 2024
1 parent 65029b0 commit a202574
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
9 changes: 8 additions & 1 deletion IBPSA/Electrical/Interfaces/Load.mo
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ model Load "Partial model for a generic load"
or linearized)));
parameter IBPSA.Electrical.Types.InitMode initMode(
min=IBPSA.Electrical.Types.InitMode.zero_current,
max=IBPSA.Electrical.Types.InitMode.linearized) = IBPSA.Electrical.Types.InitMode.zero_current
max=IBPSA.Electrical.Types.InitMode.linearized) = IBPSA.Electrical.Types.InitMode.linearized
"Initialization mode for homotopy operator" annotation(Dialog(tab = "Initialization"));

Modelica.Units.SI.Voltage v[:](start=PhaseSystem.phaseVoltages(V_nominal)) =
Expand Down Expand Up @@ -113,6 +113,13 @@ equation
annotation ( Documentation(revisions="<html>
<ul>
<li>
November 14, 2024, by Michael Wetter:<br/>
Changed default initialization method to using linearized model rather than zero current, as
the latter causes a division by zero in OpenModelica during the homotopy initialization.<br/>
This is for
<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/4048\">Buildings, #4048</a>.
</li>
<li>
January 30, 2019, by Michael Wetter:<br/>
Set start value for <code>P</code>.
</li>
Expand Down
4 changes: 0 additions & 4 deletions IBPSA/Resources/Scripts/BuildingsPy/conf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@
openmodelica:
comment: simulation terminated by an assertion at initialization.
simulate: false
- model_name: IBPSA.Electrical.DC.Loads.Examples.LinearizedLoad
openmodelica:
comment: '''omc'' caused ''simulation terminated by an assertion at initialization''.'
simulate: false
- model_name: IBPSA.Fluid.Examples.FlowSystem.Basic
openmodelica:
comment: '''omc'' caused ''simulation terminated by an assertion at initialization''.'
Expand Down

0 comments on commit a202574

Please sign in to comment.