Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-9109: Enabling TypeScript (ts-loader) with Webpack Encore #145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

IBX-9109: Enabling TypeScript (ts-loader) with Webpack Encore #145

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12fc955
IBX-9109: Enabling TypeScript (ts-loader) with Webpack Encore
lucasOsti Oct 17, 2024
436490b
Added support for TS to DXP v4.6
lucasOsti Oct 25, 2024
60f5a28
After CR
lucasOsti Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ibexa/commerce/4.6/encore/ibexa.webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports = (Encore) => {
'prop-types': 'PropTypes',
})
.enableSassLoader()
.enableTypeScriptLoader()
.enableReactPreset()
.enableSingleRuntimeChunk();

Expand Down
11 changes: 8 additions & 3 deletions ibexa/commerce/4.6/encore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,16 @@
"@ckeditor/ckeditor5-widget": "^40.1.0",
"@ckeditor/ckeditor5-theme-lark": "^40.1.0",
"@ckeditor/ckeditor5-code-block": "^40.1.0",
"@svgr/webpack": "^8.1.0"
"@svgr/webpack": "^8.1.0",
"ts-loader": "^9.5.1",
"ts-config-ibexa": "https://github.com/ibexa/ts-config-ibexa"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should install this package using specific tag (which currently doesn't exist probably), to avoid problems with updating config in the future.

This comment is valid for all other places as well, of course. :)

},
"dependencies": {
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react": "^18.3.1",
"react-dom": "^18.3.1",
"@types/react": "^18.3.11",
"@types/react-dom": "^18.3.1",
"typescript": "^5.6.3"
},
"license": "UNLICENSED",
"private": true,
Expand Down
1 change: 1 addition & 0 deletions ibexa/commerce/5.0/encore/ibexa.webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports = (Encore) => {
'prop-types': 'PropTypes',
})
.enableSassLoader()
.enableTypeScriptLoader()
.enableReactPreset()
.enableSingleRuntimeChunk();

Expand Down
11 changes: 8 additions & 3 deletions ibexa/commerce/5.0/encore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,16 @@
"@ckeditor/ckeditor5-widget": "^40.1.0",
"@ckeditor/ckeditor5-theme-lark": "^40.1.0",
"@ckeditor/ckeditor5-code-block": "^40.1.0",
"@svgr/webpack": "^8.1.0"
"@svgr/webpack": "^8.1.0",
"ts-loader": "^9.5.1",
"ts-config-ibexa": "https://github.com/ibexa/ts-config-ibexa"
},
"dependencies": {
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react": "^18.3.1",
"react-dom": "^18.3.1",
"@types/react": "^18.3.11",
"@types/react-dom": "^18.3.1",
"typescript": "^5.6.3"
},
"license": "UNLICENSED",
"private": true,
Expand Down
1 change: 1 addition & 0 deletions ibexa/experience/4.6/encore/ibexa.webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports = (Encore) => {
'prop-types': 'PropTypes',
})
.enableSassLoader()
.enableTypeScriptLoader()
.enableReactPreset()
.enableSingleRuntimeChunk();

Expand Down
11 changes: 8 additions & 3 deletions ibexa/experience/4.6/encore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,16 @@
"@ckeditor/ckeditor5-widget": "^40.1.0",
"@ckeditor/ckeditor5-theme-lark": "^40.1.0",
"@ckeditor/ckeditor5-code-block": "^40.1.0",
"@svgr/webpack": "^8.1.0"
"@svgr/webpack": "^8.1.0",
"ts-loader": "^9.5.1",
"ts-config-ibexa": "https://github.com/ibexa/ts-config-ibexa"
},
"dependencies": {
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react": "^18.3.1",
"react-dom": "^18.3.1",
"@types/react": "^18.3.11",
"@types/react-dom": "^18.3.1",
"typescript": "^5.6.3"
},
"license": "UNLICENSED",
"private": true,
Expand Down
1 change: 1 addition & 0 deletions ibexa/experience/5.0/encore/ibexa.webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports = (Encore) => {
'prop-types': 'PropTypes',
})
.enableSassLoader()
.enableTypeScriptLoader()
.enableReactPreset()
.enableSingleRuntimeChunk();

Expand Down
11 changes: 8 additions & 3 deletions ibexa/experience/5.0/encore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,16 @@
"@ckeditor/ckeditor5-widget": "^40.1.0",
"@ckeditor/ckeditor5-theme-lark": "^40.1.0",
"@ckeditor/ckeditor5-code-block": "^40.1.0",
"@svgr/webpack": "^8.1.0"
"@svgr/webpack": "^8.1.0",
"ts-loader": "^9.5.1",
"ts-config-ibexa": "https://github.com/ibexa/ts-config-ibexa"
},
"dependencies": {
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react": "^18.3.1",
"react-dom": "^18.3.1",
"@types/react": "^18.3.11",
"@types/react-dom": "^18.3.1",
"typescript": "^5.6.3"
},
"license": "UNLICENSED",
"private": true,
Expand Down
1 change: 1 addition & 0 deletions ibexa/headless/4.6/encore/ibexa.webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports = (Encore) => {
'prop-types': 'PropTypes',
})
.enableSassLoader()
.enableTypeScriptLoader()
.enableReactPreset()
.enableSingleRuntimeChunk();

Expand Down
11 changes: 10 additions & 1 deletion ibexa/headless/4.6/encore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,16 @@
"@ckeditor/ckeditor5-widget": "^40.1.0",
"@ckeditor/ckeditor5-theme-lark": "^40.1.0",
"@ckeditor/ckeditor5-code-block": "^40.1.0",
"@svgr/webpack": "^8.1.0"
"@svgr/webpack": "^8.1.0",
"ts-loader": "^9.5.1",
"ts-config-ibexa": "https://github.com/ibexa/ts-config-ibexa"
},
"dependencies": {
"react": "^18.3.1",
"react-dom": "^18.3.1",
"@types/react": "^18.3.11",
"@types/react-dom": "^18.3.1",
"typescript": "^5.6.3"
},
"license": "UNLICENSED",
"private": true,
Expand Down
1 change: 1 addition & 0 deletions ibexa/headless/5.0/encore/ibexa.webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports = (Encore) => {
'prop-types': 'PropTypes',
})
.enableSassLoader()
.enableTypeScriptLoader()
.enableReactPreset()
.enableSingleRuntimeChunk();

Expand Down
11 changes: 10 additions & 1 deletion ibexa/headless/5.0/encore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,16 @@
"@ckeditor/ckeditor5-widget": "^40.1.0",
"@ckeditor/ckeditor5-theme-lark": "^40.1.0",
"@ckeditor/ckeditor5-code-block": "^40.1.0",
"@svgr/webpack": "^8.1.0"
"@svgr/webpack": "^8.1.0",
"ts-loader": "^9.5.1",
"ts-config-ibexa": "https://github.com/ibexa/ts-config-ibexa"
},
"dependencies": {
"react": "^18.3.1",
"react-dom": "^18.3.1",
"@types/react": "^18.3.11",
"@types/react-dom": "^18.3.1",
"typescript": "^5.6.3"
},
"license": "UNLICENSED",
"private": true,
Expand Down
1 change: 1 addition & 0 deletions ibexa/oss/4.6/encore/ibexa.webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports = (Encore) => {
'prop-types': 'PropTypes',
})
.enableSassLoader()
.enableTypeScriptLoader()
.enableReactPreset()
.enableSingleRuntimeChunk();

Expand Down
11 changes: 10 additions & 1 deletion ibexa/oss/4.6/encore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,16 @@
"@ckeditor/ckeditor5-widget": "^40.1.0",
"@ckeditor/ckeditor5-theme-lark": "^40.1.0",
"@ckeditor/ckeditor5-code-block": "^40.1.0",
"@svgr/webpack": "^8.1.0"
"@svgr/webpack": "^8.1.0",
"ts-loader": "^9.5.1",
"ts-config-ibexa": "https://github.com/ibexa/ts-config-ibexa"
},
"dependencies": {
"react": "^18.3.1",
"react-dom": "^18.3.1",
"@types/react": "^18.3.11",
"@types/react-dom": "^18.3.1",
"typescript": "^5.6.3"
},
"license": "UNLICENSED",
"private": true,
Expand Down
1 change: 1 addition & 0 deletions ibexa/oss/5.0/encore/ibexa.webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports = (Encore) => {
'prop-types': 'PropTypes',
})
.enableSassLoader()
.enableTypeScriptLoader()
.enableReactPreset()
.enableSingleRuntimeChunk();

Expand Down
11 changes: 10 additions & 1 deletion ibexa/oss/5.0/encore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,16 @@
"@ckeditor/ckeditor5-widget": "^40.1.0",
"@ckeditor/ckeditor5-theme-lark": "^40.1.0",
"@ckeditor/ckeditor5-code-block": "^40.1.0",
"@svgr/webpack": "^8.1.0"
"@svgr/webpack": "^8.1.0",
"ts-loader": "^9.5.1",
"ts-config-ibexa": "https://github.com/ibexa/ts-config-ibexa"
},
"dependencies": {
"react": "^18.3.1",
"react-dom": "^18.3.1",
"@types/react": "^18.3.11",
"@types/react-dom": "^18.3.1",
"typescript": "^5.6.3"
},
"license": "UNLICENSED",
"private": true,
Expand Down
Loading