Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-9109: Enabling TypeScript (ts-loader) with Webpack Encore #145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Oct 17, 2024

Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-145

before executing the recipes.

"@svgr/webpack": "^8.1.0"
"@svgr/webpack": "^8.1.0",
"ts-loader": "^9.5.1",
"ts-config-ibexa": "https://github.com/ibexa/ts-config-ibexa"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should install this package using specific tag (which currently doesn't exist probably), to avoid problems with updating config in the future.

This comment is valid for all other places as well, of course. :)

@lucasOsti lucasOsti force-pushed the IBX-9109-enabling-typescript branch 2 times, most recently from 4014893 to 6e2f189 Compare November 12, 2024 12:15
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants