Add test coverage for WebSocket messages #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shift responsibility for sending WebSocket messages from each action function to the submit action view, because it is common behavior so shouldn't be repeated. This will also make it easier to setup testing for WebSocket messages.
Enable test running and debugging through VS Code, using pytest. Also remove Django Debug Toolbar because it was causing issues when running the tests through VS Code, and I haven't really used it since I added it.
Improve the Senator admin page to improve developer experience.
Add coverage for WebSocket messages in the mortality phase tests. The test only checks that the correct number of messages are produced, not what the messages contain, which isn't ideal but it's better than nothing.
Allow the frontend to notice Faction updates in WebSocket messages. It should have been able to do this already, but it had been missed. This change fixes the bug where faction rank changes weren't showing up in the frontend unless the page was refreshed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test coverage for the WebSocket messages that are generated when actions are processed. The new coverage revealed the cause of #347 was in the frontend. This PR includes the fix.
Also, add VS Code integration for Django tests, which enables tests to be debugged: