Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to process WebSocket messages on faction rank changes #347

Closed
iamlogand opened this issue Nov 19, 2023 · 1 comment · Fixed by #351
Closed

Failure to process WebSocket messages on faction rank changes #347

iamlogand opened this issue Nov 19, 2023 · 1 comment · Fixed by #351
Labels
bug Bug or bug fix

Comments

@iamlogand
Copy link
Owner

iamlogand commented Nov 19, 2023 •
edited
Loading

The frontend is failing to process faction rank changes via WebSocket messages upon the death of a Temporary Rome Consul. The user must refresh to see factions and actions in the correct order, which is bad.
@iamlogand iamlogand added the bug Bug or bug fix label Nov 19, 2023
@iamlogand iamlogand changed the title Failure to issue WebSocket messages on faction rank changes Failure to process WebSocket messages on faction rank changes Dec 2, 2023
@iamlogand
Copy link
Owner Author

Issue was with the frontend - it couldn't process WebSocket messages for factions.

@iamlogand iamlogand linked a pull request Dec 2, 2023 that will close this issue
Add test coverage for WebSocket messages #351
Merged
@iamlogand iamlogand mentioned this issue Dec 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug or bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test coverage for WebSocket messages iamlogand/republic-of-rome-online
1 participant
@iamlogand