Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logo #22

Merged
merged 9 commits into from
Feb 15, 2024
Merged

Add Logo #22

merged 9 commits into from
Feb 15, 2024

Conversation

jlaehne
Copy link
Member

@jlaehne jlaehne commented Jan 16, 2024

  • Add logo
  • Change spelling to eXSpy to align with logo
  • being at it change copyright notice to 2024
  • replace remaining mentioning of the 'HyperSpy developers' instead of 'eXSpy developers'
    Closes Making a Logo #17

Progress of the PR

  • Change implemented (can be split into several points),
  • docstring updated (if appropriate),
  • update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:exspy build of this PR (link in github checks)
  • ready for review.

@jlaehne jlaehne added the documentation Improvements or additions to documentation label Jan 16, 2024
@jlaehne jlaehne added this to the v0.2 milestone Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4342c5) 88.09% compared to head (8254ff3) 88.09%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   88.09%   88.09%           
=======================================
  Files          67       67           
  Lines        7289     7289           
  Branches     1176     1176           
=======================================
  Hits         6421     6421           
  Misses        593      593           
  Partials      275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc/user_guide/eds.rst Outdated Show resolved Hide resolved
and install it using (requires ``pip``):

.. code-block:: bash

pip install exspy
pip install eXSpy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be working but usually library name are all lower case, wouldn't be better to use the lower case here too (and below)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought I did a case sensitive replace, but also all occurences in that file are fixed now, as well as some links.

@ericpre ericpre mentioned this pull request Feb 14, 2024
5 tasks
@ericpre ericpre merged commit bc2cbbd into hyperspy:main Feb 15, 2024
17 of 18 checks passed
@jlaehne jlaehne deleted the logo branch February 15, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making a Logo
2 participants